Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Move Call View Buttons into a separate component #6578

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Aug 7, 2021

This is mainly nice since it organizes things a bit more, IMO. Though, this could also be useful if we ever wanted to use the buttons for something else. An example would be a separate Call View for conferences

@SimonBrandner SimonBrandner added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 7, 2021
@SimonBrandner SimonBrandner force-pushed the task/export-call-view-buttons branch 6 times, most recently from f7321ae to 4ae7610 Compare August 8, 2021 09:13
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner added the X-Blocked The PR cannot move forward in any capacity until an action is made label Aug 8, 2021
@SimonBrandner SimonBrandner marked this pull request as ready for review August 8, 2021 16:02
@SimonBrandner SimonBrandner requested a review from a team as a code owner August 8, 2021 16:02
@SimonBrandner SimonBrandner removed the X-Blocked The PR cannot move forward in any capacity until an action is made label Aug 11, 2021
@github-actions
Copy link

This change is marked as an internal change (Task), so will not be included in the changelog.

@dbkr dbkr merged commit abba798 into matrix-org:develop Aug 11, 2021
@SimonBrandner SimonBrandner deleted the task/export-call-view-buttons branch August 12, 2021 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants